C#: REWRITE_DOTNET_RPC_SERVER env-var fallback + symlink-safe project references#8017
Merged
Conversation
… entry Allow selecting the C# RPC server (a source .csproj or pre-built dll/exe) and its version via REWRITE_DOTNET_RPC_SERVER / REWRITE_DOTNET_RPC_SERVER_VERSION environment variables, so local cross-repo development and parallel git worktrees can override the embedded tool without code changes. Add a Directory.Build.targets that normalizes ProjectReference paths to avoid symlinked-checkout restore races, and an integration test exercising the env-var fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
REWRITE_DOTNET_RPC_SERVER(andREWRITE_DOTNET_RPC_SERVER_VERSION) environment-variable fallback toCSharpRewriteRpc.Builderso the C# RPC server—a source.csprojor a pre-built dll/exe—can be selected without code changes, supporting local cross-repo development and parallel git worktrees. Adds aDirectory.Build.targetsthat lexically normalizesProjectReferencepaths to remove..segments, preventing NuGet restore races when the SDK tree is consumed through a symlink. Removes the now-unneededProduceReferenceAssemblyoverride fromOpenRewrite.csproj, and addsEnvServerEntryIntegTestwhich exercises the env-var fallback whenREWRITE_DOTNET_RPC_SERVERis set.