Fix charset misdetection causing UnmappableCharacterException for CJK…#7651
Open
XiaoSK wants to merge 3 commits into
Open
Fix charset misdetection causing UnmappableCharacterException for CJK…#7651XiaoSK wants to merge 3 commits into
XiaoSK wants to merge 3 commits into
Conversation
… content (openrewrite#7636) When EncodingDetectingInputStream detects a file as Windows-1252 due to a stray invalid UTF-8 byte, but the file actually contains CJK content in UTF-8, the decoded content will contain U+FFFD characters (from Windows-1252 undefined byte positions) that cannot be re-encoded as Windows-1252, causing UnmappableCharacterException on write-back. Add a canEncode verification in readFully(): after decoding with the detected charset, if the result cannot be re-encoded with that charset, re-decode with UTF-8 instead. This catches misdetections at the decoding stage where raw bytes are still available, and all parsers benefit automatically since readFully() is the shared entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When EncodingDetectingInputStream detects a file as Windows-1252 due to a stray invalid UTF-8 byte, but the file actually contains CJK content in UTF-8, the decoded content will contain U+FFFD characters (from Windows-1252 undefined byte positions) that cannot be re-encoded as Windows-1252, causing UnmappableCharacterException on write-back.
Add a canEncode verification in readFully(): after decoding with the detected charset, if the result cannot be re-encoded with that charset, re-decode with UTF-8 instead. This catches misdetections at the decoding stage where raw bytes are still available, and all parsers benefit automatically since readFully() is the shared entry point.