Prevent changing of org.apache.http.params package (as there's no generic migration possible) and add a comment to that effect - #96
Merged
Conversation
steve-aom-elliott
changed the title
org.apache.http.params package (as there's no generic migration possible) and add a comment to that effectorg.apache.http.params package (as there's no generic migration possible) and add a comment to that effect
…eneric migration possible) and add a comment to that effect
steve-aom-elliott
force-pushed
the
1196-comment-on-http-params-imports-or-usage
branch
from
August 12, 2025 17:58
4355f34 to
b0ab3f1
Compare
timtebeek
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Prevented changing of the
org.apache.http.paramspackage and added a comment to the first relevant import indicating that manual migration will be necessary.What's your motivation?
org.apache.http.params.HttpParams, along with all other classes in theorg.apache.http.paramspackage have been deprecated since at least version4.3of the Apache Http Client library (seen here). In their stead, there are a number of configuration classes that would be used instead, but they are context specific to what content was being put into theHttpParamsinstance and can't be easily adequately inferred in many usages from a single codebase. Since we can't migrate it, it would be best to prevent the package being changed so it can more easily be found through manual effort. This PR prevents the package from change and also adds a comment suggesting that a manual change must be undertaken, as we cannot automatically migrate it.Checklist