Replace asset & attribute select dropdowns with or-attribute-picker component. - #55
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the asset/attribute selection UI by replacing dropdown components with the or-attribute-picker component. Key changes include adding the picker dependency, creating a custom extension for regressor-specific filtering, switching to WebSocket event provider, and updating the realm display context.
- Replaces dropdown-based asset/attribute selection with
or-attribute-pickerdialog component - Adds custom filtering logic to show only attributes with required meta items for regressors
- Updates event provider configuration from POLLING to WEBSOCKET for or-asset-tree compatibility
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/pages/pages-config-editor.ts | Replaced dropdown inputs with dialog-based attribute picker, added asset loading methods, removed dropdown list state management |
| frontend/src/pages/app-layout.ts | Sets manager.displayRealm to enable or-asset-tree realm queries |
| frontend/src/index.ts | Changed eventProviderType from POLLING to WEBSOCKET |
| frontend/src/components/custom-asset-attribute-picker.ts | New custom component extending OrAssetAttributePicker with predicted datapoints filtering |
| frontend/package.json | Added @openremote/or-attribute-picker dependency |
| frontend/package-lock.json | Updated dependency tree with new packages and version updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MartinaeyNL
reviewed
Dec 10, 2025
MartinaeyNL
left a comment
Member
There was a problem hiding this comment.
Code looks OK!
I only added a few minor comments on top of the feedback Copilot already gave.
MartinaeyNL
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
Closes #52
Changes
This PR replaces the current method of selecting assets and their attributes (dropdowns) with the
or-attribute-pickercomponent.or-attribute-pickerdependency.custom-asset-attribute-picker.ts, which extends/overridesOrAssetAttributePicker.storeDataPointsand eitherhasPredictedDataPointsorhasAgentLinkmeta items.eventProviderTypetoWEBSOCKETso that theor-asset-treecomponent inside the attribute picker functions correctly, as it relies on WebSockets.manager.displayRealmso thator-asset-treeknows which realm to query for assets.Screenshots
Select target button
Select attributes dialog (attribute picker)
When an attribute has been selected
Regressors