Skip to content

Feature/ci cd signing #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wborn merged 6 commits into from
Aug 6, 2025
Merged

Feature/ci cd signing #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a340c71
ci: add PR and manual workflow triggers for CI pipeline. openremote/o…
Miggets7 Aug 6, 2025
7af2a7b
fix: enable provisioning updates in CI
Miggets7 Aug 6, 2025
787f2c9
reverted provisioning update flag from build
Miggets7 Aug 6, 2025
e812a8d
Merge branch 'main' into feature/ci_cd_signing
Miggets7 Aug 6, 2025
0eb605b
refactor: replace async with Task.init and simplify error handling in…
Miggets7 Aug 6, 2025
351c897
ci: pin macOS runner version to macos-15 for CI/CD workflow
Miggets7 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

build:
name: CI/CD
runs-on: macos-latest
runs-on: macos-15 # is not the macos-latest, which should be by the end of August 2025

steps:
- name: Checkout
Expand Down
8 changes: 2 additions & 6 deletions GenericApp/GenericApp/UI/WizardDomainViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ extension WizardDomainViewController: UITextFieldDelegate {
}

fileprivate func requestAppConfig(_ domain: String) {
async {
Task.init {
do {
configManager = ConfigManager(apiManagerFactory: { url in
try HttpApiManager(baseUrl: url)
HttpApiManager(baseUrl: url)
Comment thread
wborn marked this conversation as resolved.
})

let state = try await configManager!.setDomain(domain: domain)
Expand All @@ -124,10 +124,6 @@ extension WizardDomainViewController: UITextFieldDelegate {
case.complete:
self.performSegue(withIdentifier: Segues.goToWebView, sender: self)
}
Comment thread
wborn marked this conversation as resolved.
} catch ApiManagerError.invalidUrl {
let alertView = UIAlertController(title: "Error", message: "Invalid domain.\nCheck your input and try again.", preferredStyle: .alert)
alertView.addAction(UIAlertAction(title: "OK", style: .default, handler: nil))
self.present(alertView, animated: true, completion: nil)
} catch {
let alertView = UIAlertController(title: "Error", message: "Error occurred getting app config.\nCheck your input and try again.", preferredStyle: .alert)
alertView.addAction(UIAlertAction(title: "OK", style: .default, handler: nil))
Expand Down