ci(apps): rename the signing environment to native-macos - #228
Conversation
|
All contributors have signed the CLA — thank you! ✍️ ✅ Posted by the CLA bot. |
f798f11 to
601575a
Compare
Greptile SummaryRenames the macOS signing environment from
Confidence Score: 4/5The PR appears safe to merge once its explicitly documented environment prerequisite is satisfied; only a minor documentation grammar issue remains. The workflow and documentation consistently use the new environment name, while the sole accepted issue is an incorrect article in the updated README. Files Needing Attention: apps/native-viewer/macos/README.md
|
| Filename | Overview |
|---|---|
| .github/workflows/macos-app.yml | Renames the signing job environment consistently; the externally managed environment migration is explicitly documented as a merge prerequisite. |
| apps/native-viewer/macos/README.md | Updates both environment references but introduces the grammatical phrase “an macos-native environment”. |
Reviews (1): Last reviewed commit: f798f11 | Re-trigger Greptile
| ## Secrets | ||
|
|
||
| Create an `apple-signing` environment with required reviewers, then create | ||
| Create an `macos-native` environment with required reviewers, then create |
There was a problem hiding this comment.
Incorrect article before environment name
The updated instruction uses an before macos-native, leaving a grammatical error in the setup documentation; it should read “Create a macos-native environment”.
| Create an `macos-native` environment with required reviewers, then create | |
| Create a `macos-native` environment with required reviewers, then create |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Co-Authored-By: codex <codex@openai.com>
A tag push that reaches the sign job with incomplete Apple credentials now fails instead of quietly retaining the unsigned artifact. Manual dispatches keep the soft fallback so branch builds outside the environment allowlist still produce something inspectable.
80a403b to
663a6bc
Compare
TL;DR:
Summary:
apple-signingtonative-macos, and updates the reference inapps/native-viewer/macos/README.mdnative-*groups the native apps as one family, so a future Linux pipeline sits alongside asnative-linuxrather than scattering by platformMerge only after the environment exists under the new name. Otherwise the signing job resolves an environment with no secrets and quietly produces an unsigned build instead of failing. Either rename
apple-signingin place from Settings → Environments, which preserves the secrets, or createnative-macosand re-add the six secrets first.Test plan:
native-macosexists and holds all six Apple secrets-unsignedsuffixapple-signingenvironment