Skip to content

ci(apps): rename the signing environment to native-macos - #228

Open
eliahilse wants to merge 2 commits into
mainfrom
ci/rename-signing-env
Open

ci(apps): rename the signing environment to native-macos#228
eliahilse wants to merge 2 commits into
mainfrom
ci/rename-signing-env

Conversation

@eliahilse

@eliahilse eliahilse commented Aug 22, 2026

Copy link
Copy Markdown
Member

TL;DR:

Summary:

  • renames the deployment environment the signing job declares from apple-signing to native-macos, and updates the reference in apps/native-viewer/macos/README.md
  • native-* groups the native apps as one family, so a future Linux pipeline sits alongside as native-linux rather than scattering by platform

Merge only after the environment exists under the new name. Otherwise the signing job resolves an environment with no secrets and quietly produces an unsigned build instead of failing. Either rename apple-signing in place from Settings → Environments, which preserves the secrets, or create native-macos and re-add the six secrets first.

Test plan:

  • the environment native-macos exists and holds all six Apple secrets
  • run the workflow manually and confirm the artifact name has no -unsigned suffix
  • delete the now-unused apple-signing environment

@openooxml-bot

openooxml-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA — thank you! ✍️ ✅

Posted by the CLA bot.

@eliahilse
eliahilse force-pushed the ci/rename-signing-env branch from f798f11 to 601575a Compare August 22, 2026 23:22
@eliahilse eliahilse changed the title ci(apps): rename the signing environment to macos-native ci(apps): rename the signing environment to native-macos Aug 22, 2026
@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown

Greptile Summary

Renames the macOS signing environment from apple-signing to macos-native in the workflow and its setup documentation.

  • Updates the signing job’s GitHub environment declaration.
  • Updates the README’s environment-gate and secret-configuration instructions.

Confidence Score: 4/5

The PR appears safe to merge once its explicitly documented environment prerequisite is satisfied; only a minor documentation grammar issue remains.

The workflow and documentation consistently use the new environment name, while the sole accepted issue is an incorrect article in the updated README.

Files Needing Attention: apps/native-viewer/macos/README.md

Important Files Changed

Filename Overview
.github/workflows/macos-app.yml Renames the signing job environment consistently; the externally managed environment migration is explicitly documented as a merge prerequisite.
apps/native-viewer/macos/README.md Updates both environment references but introduces the grammatical phrase “an macos-native environment”.

Reviews (1): Last reviewed commit: f798f11 | Re-trigger Greptile

Comment thread apps/native-viewer/macos/README.md Outdated
## Secrets

Create an `apple-signing` environment with required reviewers, then create
Create an `macos-native` environment with required reviewers, then create

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Incorrect article before environment name

The updated instruction uses an before macos-native, leaving a grammatical error in the setup documentation; it should read “Create a macos-native environment”.

Suggested change
Create an `macos-native` environment with required reviewers, then create
Create a `macos-native` environment with required reviewers, then create

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

eliahilse and others added 2 commits August 26, 2026 00:17
Co-Authored-By: codex <codex@openai.com>
A tag push that reaches the sign job with incomplete Apple credentials
now fails instead of quietly retaining the unsigned artifact. Manual
dispatches keep the soft fallback so branch builds outside the
environment allowlist still produce something inspectable.
@eliahilse
eliahilse force-pushed the ci/rename-signing-env branch from 80a403b to 663a6bc Compare August 25, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant