Skip to content

Issue #104: Display an alert if componentDidMount catches an error - #122

Open
gudetimes1234 wants to merge 1 commit into
openoakland:masterfrom
gudetimes1234:CG_issues_104_error_handling_for_API_requests
Open

Issue #104: Display an alert if componentDidMount catches an error#122
gudetimes1234 wants to merge 1 commit into
openoakland:masterfrom
gudetimes1234:CG_issues_104_error_handling_for_API_requests

Conversation

@gudetimes1234

Copy link
Copy Markdown

#104

when a request fails:
the user should be informed that an error has occurred

It's been a while for me with React, but I went ahead and updated this.
Hope it's okay that I added lodash. I just like to use it.

@gudetimes1234 gudetimes1234 changed the title Display an alert if componentDidMount catches an error Issue #104: Display an alert if componentDidMount catches an error May 31, 2018
@nydame
nydame requested a review from macfarlandian July 3, 2019 03:16
@nydame

nydame commented Jul 3, 2019

Copy link
Copy Markdown
Collaborator

@gudetimes1234 Thanks for you input. The project was on hiatus for a while, but now we're active again. I've assigned a reviewer (the person whose code you modified) to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants