Skip to content

refactor(docs): add direct migration link and ng add command - #1443

Merged
geromegrignon merged 1 commit into
mainfrom
refactor-lading-docs
Aug 6, 2026
Merged

refactor(docs): add direct migration link and ng add command#1443
geromegrignon merged 1 commit into
mainfrom
refactor-lading-docs

Conversation

@geromegrignon

Copy link
Copy Markdown
Contributor

Description

Related issues

Fixes #

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes the public API)
  • Documentation only
  • Refactor, test, or chore (no user-facing change)

Breaking changes

None

Test plan

  • npm run build
  • npm test
  • npm run lint
  • Verified in the demo app (if applicable)

Checklist

  • Issue discussed or bug clearly described (link issue when applicable)
  • Tests added or updated for behavioral changes
  • Documentation updated (README, JSDoc, migration notes as needed)
  • Public API changes documented; breaking changes called out
  • CHANGELOG updated (if the repository maintains one and the change is user-facing)
  • Commit messages follow Conventional Commits
  • I agree to follow the OpenNG Foundation Code of Conduct

Additional context

Copilot AI lite review requested due to automatic review settings August 5, 2026 08:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the docs landing page hero section to better direct new users by highlighting PrimeNG migration guidance and showing a one-click “ng add” install command.

Changes:

  • Replaces the “Give a Star” GitHub CTA with a direct “Migrate from PrimeNG” link.
  • Adds an ng add @openng/optimus-ui command pill with a copy-to-clipboard button.
  • Implements clipboard copy behavior with visual “Copied!” feedback state.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/docs/pages/landing/herosection.component.ts
Comment on lines +71 to +72
<div class="flex items-center gap-3 mt-12 bg-surface-100 dark:bg-surface-800 border border-black/10 dark:border-white/10 rounded-full py-2 pl-5 pr-2">
<code class="font-mono text-sm text-surface-700 dark:text-surface-300">ng add &#64;openng/optimus-ui</code>
Comment thread apps/docs/pages/landing/herosection.component.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

apps/docs/pages/landing/herosection.component.ts:1047

  • setTimeout(() => (this.commandCopied = false), 2000) can race if the user clicks the copy button multiple times: an earlier timeout may flip commandCopied back to false sooner than 2s after the most recent click. Track the timeout handle so you can clear/restart it on each successful copy (and clear it in ngOnDestroy).
            .then(() => {
                this.commandCopied = true;
                setTimeout(() => (this.commandCopied = false), 2000);
            })

@geromegrignon
geromegrignon merged commit 820a69a into main Aug 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants