Skip to content

fix(confirmpopup): accept/reject button props label were not rendering - #1438

Open
SoyDiego wants to merge 1 commit into
openng-org:mainfrom
SoyDiego:fix/confirmpopup-button-props-label
Open

fix(confirmpopup): accept/reject button props label were not rendering#1438
SoyDiego wants to merge 1 commit into
openng-org:mainfrom
SoyDiego:fix/confirmpopup-button-props-label

Conversation

@SoyDiego

@SoyDiego SoyDiego commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

If you pass a label through acceptButtonProps / rejectButtonProps in ConfirmPopup, it never shows up. You get the default translated label instead.

I also tried typing acceptButtonProps / rejectButtonProps / closeButtonProps as ButtonProps instead of any, but it breaks the build:

Entry point @openng/optimus-ui/api has a circular dependency on @openng/optimus-ui/types/button

types/button imports PassThrough from api, and api is the base entry point, so it can't import back. Fixing it means moving the passthrough types out of api into their own entry point. That's a bigger change, so I left the any alone here.

image

Related issues

fix #40

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes the public API)
  • Documentation only
  • Refactor, test, or chore (no user-facing change)

Test plan

  • npm run build
  • npm test
  • npm run lint
  • Verified in the demo app (if applicable)

Checklist

  • Issue discussed or bug clearly described (link issue when applicable)
  • Tests added or updated for behavioral changes
  • Documentation updated (README, JSDoc, migration notes as needed)
  • Public API changes documented; breaking changes called out
  • CHANGELOG updated (if the repository maintains one and the change is user-facing)
  • Commit messages follow Conventional Commits
  • I agree to follow the OpenNG Foundation Code of Conduct

@SoyDiego

SoyDiego commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Hi @geromegrignon, I created this PR again for the new version of Optimus UI because my previous PR became obsolete due to all the changes.

Thanks!

@geromegrignon geromegrignon added this to the Catch-up milestone Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

confirmPopup: acceptButtonProps/rejectButtonProps properties ignored

2 participants