feat(i18n): change wording for zh-TW - #1424
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Pull request overview
Updates the Traditional Chinese (Taiwan) locale strings to use more common local wording, improving the UI’s tone and terminology consistency for zh-TW users.
Changes:
- Refined multiple general UI action/label translations (e.g., accept/apply/filter, empty-state messages).
- Adjusted date/time and navigation-related wording (e.g., next/prev year, selection message).
- Updated several ARIA/accessibility labels to align with revised terminology (e.g., “過濾”, “列”, “檢視”).
Suppressed comments (1)
packages/optimus-ui-locale/src/zh-TW.json:128
startsWithis the string-match operator label (“Starts with”). The new translation “開始於” reads like “starts at (a time/place)” and can be misleading for text matching. Consider wording that explicitly means “starts with”, consistent with the operator semantics.
"startsWith": "開始於",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "emptyMessage": "沒有可用項目", | ||
| "emptySearchMessage": "沒有相關搜尋結果", | ||
| "emptySelectionMessage": "沒有選取的項目", | ||
| "endsWith": "結束於", |
endsWith is the string-match operator label (“Ends with”). The new translation “結束於” reads like “ends at (a time/place)” and can be misleading for text matching. Consider wording that explicitly means “ends with”, consistent with the operator semantics. This issue also appears on line 128 of the same file.
|
@yrctw is attempting to deploy a commit to the Gerome Grignon Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR will need to be reviewed by a native Taiwanese speaker because Claude alone provided me with feedback about inconsistent terms compared to the other languages than i can review myself. Concerns worth raising on the PR
datepicker.ts:1288 uses nextYear as the aria label for the forward-navigation button when the picker is in month view. It means "advance the displayed year," not "the year after today." 明年/去年 are anchored to the real current year, so a user browsing 1985 hears "next year / last year." The old 下一年/上一年 was correct. Ask for a revert on these two.
These aren't aria labels; they're the default button labels in ConfirmDialog and ConfirmPopup. The English source is "Yes" / "No", and 是/否 mirrored that. 接受/拒絕 changes what every existing zh-TW confirm dialog renders, and reads oddly for a "Are you sure you want to delete?" prompt. aria.trueLabel/falseLabel are still 是/否, so the file is now internally inconsistent on the same two words. I'd push back or split this out.
For data-grid filtering, 篩選 is the established Taiwan convention (it's what Microsoft Office and Apple ship in zh-TW). 過濾 is understood but leans toward "filter out" and is more common in mainland-influenced technical writing — which is ironic given the PR's stated goal. The author applied it consistently, so it's not sloppy, but this one really needs a second native zh-TW reviewer before merge.
cancelEdit / saveEdit ("Cancel Edit" / "Save Edit") became 取消變更 / 儲存變更 ("cancel/save changes"). Fine in isolation, but it's re-scoping the string rather than translating it. And emptyFilterMessage → 沒有符合過濾條件的結果 is 10 characters, noticeably longer than the old 6 — could wrap in narrow dropdowns. |
- accroding to datePicker, nextYear / prevYear，上一年/下一年 is better wording than 去年/明年 - accept / reject revert back to yes (是) / no (否) meaning - I came up with the Thunderbird Mail app, the filter function is named 篩選 rather than 過濾, so I reverted it back - emptyFilterMessage and emptySearchMessage can be narrow to the same "沒有符合的結果" but it will lost the difference of filter and search
|
Description
Modified to be a common expression used by local Taiwanese people.