fix(treeselect): emit onFilter when the user types in the filter input - #1421
Open
marmotz wants to merge 1 commit into
Open
fix(treeselect): emit onFilter when the user types in the filter input#1421marmotz wants to merge 1 commit into
marmotz wants to merge 1 commit into
Conversation
marmotz
force-pushed
the
256-treeselect-onfilter-event
branch
from
July 31, 2026 18:42
ce003fe to
3e35351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
p-treeSelect'sonFilteroutput was never emitted: the component's ownonFilterInputmethod was dead code, since the filter<input>is actually rendered inside the internalp-tree(which has its ownonFilteroutput that nothing was listening to).This fix wires
(onFilter)="onFilterInput($event)"on the internal<p-tree>, and updatesonFilterInputto accept theTreeFilterEventemitted byp-tree, syncfilterValue/filteredNodes, and re-emit it asTreeSelect's ownonFilterevent.Before: typing in the filter box never fired
onFilteronp-treeSelect.After:
onFilterfires with the currentfiltervalue andfilteredValue, as documented.Related issues
Fixes #256
Type of change
Breaking changes
None
Test plan
npm run buildnpm testnpm run lintChecklist
Additional context
Multiple users confirmed the same root cause and workaround in the issue comments (subscribing to the internal
p-tree'sonFilterand relaying it manually), this PR implements the equivalent fix directly inTreeSelect.