fix(multiselect): do not select focused option on tab - #1419
Open
jase88 wants to merge 1 commit into
Open
Conversation
Tab is a focus-navigation key per WAI-ARIA Authoring Practices: it moves focus and closes the popup without changing selection. Selecting the focused option on Tab made tabbing away behave like Enter/Space. Closes openng-org#395
Contributor
Author
|
@geromegrignon @dominicbachmann |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #395
By WAI-ARIA Authoring Practices, Tab is a focus-navigation key. It should move focus to the next focusable element (Shift+Tab to the previous) and, if the popup is open, typically close it without changing selection.
Selection should only change with Space/Enter, not Tab.
Changes
onTabKeyno longer selects the focused option before closing the overlay.eventparameter asKeyboardEvent.