O3-5674: add visit notes section to visit summary PDF#30
Open
BlessedAmrita wants to merge 1 commit into
Open
Conversation
|
Contributor
Author
Member
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Adds a VisitNotesSection to the visit summary PDF, showing the free-text clinical notes recorded during the visit. Follows the TypedSection architecture from #16
What this does
report.visitSummary.visitNotes.concept(default CIEL:162169), resolved by mapping so a non-CIEL deployment can retarget without touching Java.No path silently drops a note.
Scope decision
Visit-scoped: notes recorded under this visit's non-voided encounters, not the patient's note history — same encounter filter as Vitals/Diagnoses. Narrative only;
Testing
17 new integration tests (multi-note ordering, empty states, blank-value placeholder, missing/other-role provider, unresolvable-concept error, voided exclusion, XML structure); full suite green. Verified end-to-end by rendering sample XML through the production FOP config — which surfaced a missing section-notice hook in the stylesheet, now fixed.
Related
Ticket: https://openmrs.atlassian.net/browse/O3-5674