Skip to content

Migrate to the reusable GHA#75

Merged
ibacher merged 9 commits into
openmrs:mainfrom
wikumChamith:gha
Jul 8, 2026
Merged

Migrate to the reusable GHA#75
ibacher merged 9 commits into
openmrs:mainfrom
wikumChamith:gha

Conversation

@wikumChamith

Copy link
Copy Markdown
Member

No description provided.

Comment thread .github/workflows/main.yml Outdated
run: |
mvn clean verify --batch-mode --file pom.xml

owasp-dependency-check:

@ibacher ibacher Jun 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point in running this:

  1. The content package has no dependencies
  2. The content package has no code

Consequently, it's not the kind of thing OWASP can detect, etc.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTOH, why wouldn't we change the rest of the workflow to use the default build workflow?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher problem is that the reusable build-backend-module workflow is written specifically for backend OMOD modules, and this repo is a content package.

ex:

https://github.com/openmrs/openmrs-contrib-gha-workflows/blob/342997ba45ca67ac2812bf955adef1706ed48391/.github/workflows/build-backend-module.yml#L192

@ibacher ibacher Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that is a workflow called "build-backend-module" not "build-maven-project", so I guess I', fine with that. Maybe we can factor out something less module-specific for content packages, etc.?

@wikumChamith

Copy link
Copy Markdown
Member Author

@ibacher I decided to leave the build job as it is and only move the release job to use our common GHA.

@ibacher ibacher changed the title Migrate to the reusable GHA. Migrate to the reusable GHA Jul 8, 2026
@ibacher
ibacher merged commit 2f738af into openmrs:main Jul 8, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants