fix: make service instance reconciler ignore status changes - #59
Draft
Diaphteiros wants to merge 3 commits into
Draft
fix: make service instance reconciler ignore status changes#59Diaphteiros wants to merge 3 commits into
Diaphteiros wants to merge 3 commits into
Conversation
Signed-off-by: Johannes Aubart <johannes.aubart@sap.com>
Signed-off-by: Johannes Aubart <johannes.aubart@sap.com>
christophrj
self-requested a review
September 4, 2026 16:16
On-behalf-of: @SAP christopher.junk@sap.com Signed-off-by: Christopher Junk <christopher.junk@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Service providers are usually the only controller modifying a service instance resource's status, which means that they don't need to react to status changes, as they caused them themselves.
Excluding status changes from triggering reconciliations reduces the chance for infinite reconciliation loops, which will otherwise happen if the service resource's status changes with every reconciliation.
Which issue(s) this PR fixes:
Fixed a problem with the service provider ODG.
Special notes for your reviewer:
Currently a draft because we want to add the option to overwrite the default predicates.
Release note: