fix: no longer require a repository context in component descriptors - #305
Open
piotrjanik wants to merge 3 commits into
Open
fix: no longer require a repository context in component descriptors#305piotrjanik wants to merge 3 commits into
piotrjanik wants to merge 3 commits into
Conversation
The legacy OCM spec mandated at least one repository context, but OCM v2 component descriptors no longer carry one. Drop the checks so component versions from OCM v2 repositories can be resolved. Signed-off-by: Piotr Janik <piotr.janik@sap.com>
piotrjanik
force-pushed
the
fix/1235-repository-context
branch
from
September 1, 2026 13:23
f700006 to
2f09fc8
Compare
piotrjanik
changed the title
piotrjanik
marked this pull request as ready for review
September 1, 2026 13:25
Contributor
|
The failed check is because the PR description is missing a |
The legacy OCM spec mandated at least one repository context, but OCM v2 component descriptors no longer carry one. Drop the checks so component versions from OCM v2 repositories can be resolved. Signed-off-by: Piotr Janik <piotr.janik@sap.com>
Contributor
|
@piotrjanik Seems there is an unused variable now. |
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
Author
|
@Diaphteiros, how about now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The legacy OCM spec mandated at least one repository context, but OCM v2 component descriptors no longer carry one. Drop the checks so component versions from OCM v2 repositories can be resolved.
Which issue(s) this PR fixes:
Fixes open-component-model/ocm-project#1235
Special notes for your reviewer:
Release note: