Skip to content

fix: return missing client_id in GetOIDCProvider#321

Merged
cb80 merged 1 commit into
mainfrom
returnClientIDInGetOIDCProvider
Jun 26, 2026
Merged

fix: return missing client_id in GetOIDCProvider#321
cb80 merged 1 commit into
mainfrom
returnClientIDInGetOIDCProvider

Conversation

@cb80

@cb80 cb80 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cb80 cb80 self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 201a00fa-dc40-4ed2-9de0-b9610b585c80

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cb80 cb80 force-pushed the returnClientIDInGetOIDCProvider branch 2 times, most recently from e169428 to 701d4bf Compare June 24, 2026 14:15
@cb80 cb80 marked this pull request as ready for review June 24, 2026 14:26
petersbingham
petersbingham previously approved these changes Jun 25, 2026
aselyecan
aselyecan previously approved these changes Jun 25, 2026
@cb80 cb80 dismissed stale reviews from aselyecan and petersbingham via 477f329 June 25, 2026 12:58
@cb80 cb80 force-pushed the returnClientIDInGetOIDCProvider branch from acd2769 to 477f329 Compare June 25, 2026 12:58

@alienvspredator alienvspredator left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me, just a small comment.

Comment thread go.mod Outdated
@cb80 cb80 force-pushed the returnClientIDInGetOIDCProvider branch from 477f329 to 21355e6 Compare June 25, 2026 13:48
Signed-off-by: Chris Burkert <burkert.chris@gmail.com>
@cb80 cb80 force-pushed the returnClientIDInGetOIDCProvider branch from 21355e6 to d62abe3 Compare June 25, 2026 14:03
Comment thread sql/00005_client_id.go
}

// Read the client_id from the config
//nolint:staticcheck

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked claude about this change:

Is modifying a goose migration file safe?

Yes, in this specific case it is safe. Here's why:

  1. Goose tracks migrations by filename/number, not content hash. Once migration 00005 has run on a database, goose records it in the goose_db_version table by its sequence number. It does not re-run migrations or detect content changes.

  2. This is a Go migration, not a SQL migration. The Go code only executes during goose up when the migration hasn't been applied yet. Databases that have already run this migration will never execute this code again.

  3. The change is purely cosmetic. Fixing the //nolint directive doesn't change the migration's behavior — it only satisfies the linter.

@petersbingham petersbingham self-requested a review June 26, 2026 12:26
@cb80 cb80 merged commit f10b896 into main Jun 26, 2026
7 checks passed
@cb80 cb80 deleted the returnClientIDInGetOIDCProvider branch June 26, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants