fix: return missing client_id in GetOIDCProvider#321
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e169428 to
701d4bf
Compare
acd2769 to
477f329
Compare
alienvspredator
left a comment
There was a problem hiding this comment.
LGTM for me, just a small comment.
477f329 to
21355e6
Compare
Signed-off-by: Chris Burkert <burkert.chris@gmail.com>
21355e6 to
d62abe3
Compare
| } | ||
|
|
||
| // Read the client_id from the config | ||
| //nolint:staticcheck |
There was a problem hiding this comment.
I asked claude about this change:
Is modifying a goose migration file safe?
Yes, in this specific case it is safe. Here's why:
-
Goose tracks migrations by filename/number, not content hash. Once migration
00005has run on a database, goose records it in thegoose_db_versiontable by its sequence number. It does not re-run migrations or detect content changes. -
This is a Go migration, not a SQL migration. The Go code only executes during
goose upwhen the migration hasn't been applied yet. Databases that have already run this migration will never execute this code again. -
The change is purely cosmetic. Fixing the
//nolintdirective doesn't change the migration's behavior — it only satisfies the linter.
No description provided.