Skip to content

feat: modules support#296

Open
alienvspredator wants to merge 5 commits into
mainfrom
feature/extension-support
Open

feat: modules support#296
alienvspredator wants to merge 5 commits into
mainfrom
feature/extension-support

Conversation

@alienvspredator

@alienvspredator alienvspredator commented May 18, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Add modules support to the session manager, define and implement standard `trust` and `database` modules.

Special notes for your reviewer:

The modules are statically linked at built-time.
Custom-built session manager with other modules can be built by altering imports in the main.go file. The main() body remains unchanged (makes a call to maincmd.Main()).

Release note:

- Support statically linked modules at build time.
- Implement `trust` module with OIDC.
- Implement `database` module with pgxpool.

feat: module extensions

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alienvspredator alienvspredator force-pushed the feature/extension-support branch from 85fbad9 to f0e17e2 Compare May 18, 2026 09:57
@alienvspredator alienvspredator force-pushed the feature/extension-support branch 8 times, most recently from 710cacf to ba47cb2 Compare May 18, 2026 13:30
@openkcm openkcm deleted a comment from coderabbitai Bot May 18, 2026
@alienvspredator alienvspredator force-pushed the feature/extension-support branch 7 times, most recently from 70549ee to 47d3a66 Compare May 27, 2026 08:50
Comment thread modules/oidctrust/module.go Outdated
Comment thread internal/config/config.go
"time"

"github.com/creasty/defaults"
"github.com/knadh/koanf/v2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use viper for this, so do we really need koanf?
Especially as one of its deps github.com/mitchellh/copystructure is archived.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use viper for this use-case. Viper can't parse and store ambiguous values, as well as some issues with Viper:

So we can't really use Viper here.

Comment thread context.go Outdated
@alienvspredator alienvspredator force-pushed the feature/extension-support branch from 47d3a66 to 8f02e4c Compare June 2, 2026 07:43
@alienvspredator alienvspredator force-pushed the feature/extension-support branch 2 times, most recently from 0758404 to 299e11b Compare June 23, 2026 07:20
@alienvspredator alienvspredator requested a review from cb80 June 23, 2026 08:21
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
@alienvspredator alienvspredator force-pushed the feature/extension-support branch from 299e11b to dd47031 Compare June 23, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants