feat: modules support#296
Open
alienvspredator wants to merge 5 commits into
Open
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
85fbad9 to
f0e17e2
Compare
710cacf to
ba47cb2
Compare
70549ee to
47d3a66
Compare
cb80
requested changes
May 27, 2026
| "time" | ||
|
|
||
| "github.com/creasty/defaults" | ||
| "github.com/knadh/koanf/v2" |
Contributor
There was a problem hiding this comment.
We usually use viper for this, so do we really need koanf?
Especially as one of its deps github.com/mitchellh/copystructure is archived.
Member
Author
There was a problem hiding this comment.
We can't use viper for this use-case. Viper can't parse and store ambiguous values, as well as some issues with Viper:
- viper breaks JSON, YAML, TOML, HCL language specs by Add viper.SetKeysCaseSensitive() to disable automatic key lowercasing. spf13/viper#635.
- hardcoded parsers
So we can't really use Viper here.
47d3a66 to
8f02e4c
Compare
0758404 to
299e11b
Compare
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
299e11b to
dd47031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
Release note:
feat: module extensions