8387124: Incomplete algorithm decomposition for TLS 1.3 cipher suites in SSLAlgorithmDecomposer

[chmielewskiandreas]

Hi, this is a clean backport of 3f52251

Testing:

make run-test TEST="jdk_security"
make run-test TEST="test/jdk/javax/net/ssl/ciphersuites/BulkCipherDisabledAlgorithms.java test/jdk/sun/security/ssl/CipherSuite/TLS13BulkCipherDisabledCipherSuite.java"

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8387124 needs maintainer approval

Issue

• JDK-8387124: Incomplete algorithm decomposition for TLS 1.3 cipher suites in SSLAlgorithmDecomposer (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk27u.git pull/13/head:pull/13
$ git checkout pull/13

Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jdk27u.git pull/13/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13

View PR using the GUI difftool:
$ git pr show -t 13

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk27u/pull/13.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back achmielewski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[chmielewskiandreas]

/template append

[openjdk]

@chmielewskiandreas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8387124: Incomplete algorithm decomposition for TLS 1.3 cipher suites in SSLAlgorithmDecomposer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

• bed1e7a: 8389230: Update the release version and date for OpenJDK 27u
• 4664016: Merge
• 1c4ab23: 8387722: The race during initialization or lazy constants in and Map/Set
• ... and 69 more: https://git.openjdk.org/jdk27u/compare/f19fc30b3cafd009f1b36379b5ce2dbc7b4344de...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@chmielewskiandreas The pull request template has been appended to the pull request body

[chmielewskiandreas]

/approval request

I am proposing this clean backport.

I would classify the backport risk as low, with the main risk being behavioral compatibility. The issue addresses incomplete decomposition of TLS 1.3 cipher suites, which caused jdk.tls.disabledAlgorithms constraints such as AES_128_GCM, AES_256_GCM, and CHACHA20_POLY1305 to not consistently match the corresponding TLS cipher suites.

As a result, disabling these algorithms may not disable the corresponding TLS 1.3 cipher suites as expected. This change makes the behavior consistent with other cipher suites and ensures that the configured algorithm constraints are applied correctly.

[openjdk]

⚠️ @chmielewskiandreas This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@chmielewskiandreas
8387124: The approval request has been created successfully.

[mlbridge]

Webrevs

• 03: Full - Incremental (1665db91)
• 02: Full - Incremental (91bc1e74)
• 01: Full - Incremental (d6a61def)
• 00: Full (c8831fbc)

[chmielewskiandreas]

/approval request cancel

[openjdk]

@chmielewskiandreas
8387124: The approval request has been updated successfully.

[chmielewskiandreas]

/approval request

The change applies cleanly, although it is not marked as a clean backport. It consists of:

• JDK-8387124, the original fix, and
• JDK-8387874, a follow-up improvement that reduces the number of spawned VMs and avoids excessive resource consumption in CI.

I would classify the backport risk as low, with the main risk being behavioral compatibility. The issue addresses incomplete decomposition of TLS 1.3 cipher suites, which caused jdk.tls.disabledAlgorithms constraints such as AES_128_GCM, AES_256_GCM, and CHACHA20_POLY1305 to not consistently match the corresponding TLS cipher suites.

As a result, disabling these algorithms may not disable the corresponding TLS 1.3 cipher suites as expected. This change makes the behavior consistent with other cipher suites and ensures that the configured algorithm constraints are applied correctly.

[openjdk]

@chmielewskiandreas
8387124: Approval has already been requested and approved.

[GoeLin]

HI @chmielewskiandreas
please also backport the follow-up test fix.
Thanks, Goetz.

[chmielewskiandreas]

HI @chmielewskiandreas please also backport the follow-up test fix. Thanks, Goetz.

@GoeLin : The fix and the follow-up test fix is combined within this PR. I think it does not make sense to have two backports for the same issue.

[GoeLin]

HI @chmielewskiandreas
Ok, reading all of this made me find your comment.
But as this was a clean backport, please make two individual changes.
It might be a bit more work for you, but if looked later at the repo it's much more easy to understand.
Also, you avoid involving a reviewer. And you get faster approval for clean changes as I trust them more.
Best, Goetz.

[chmielewskiandreas]

HI @chmielewskiandreas Ok, reading all of this made me find your comment. But as this was a clean backport, please make two individual changes. It might be a bit more work for you, but if looked later at the repo it's much more easy to understand. Also, you avoid involving a reviewer. And you get faster approval for clean changes as I trust them more. Best, Goetz.

ok, that is also fine for me

[chmielewskiandreas]

/approval request

The change applies cleanly,

I would classify the backport risk as low, with the main risk being behavioral compatibility. The issue addresses incomplete decomposition of TLS 1.3 cipher suites, which caused jdk.tls.disabledAlgorithms constraints such as AES_128_GCM, AES_256_GCM, and CHACHA20_POLY1305 to not consistently match the corresponding TLS cipher suites.

As a result, disabling these algorithms may not disable the corresponding TLS 1.3 cipher suites as expected. This change makes the behavior consistent with other cipher suites and ensures that the configured algorithm constraints are applied correctly.

Please note that this change will be followed by JDK-8387874, which improves the timeout handling in this test.

[openjdk]

@chmielewskiandreas
8387124: Approval has already been requested and approved.