Skip to content

8388439: [s390x] LoadNKlass rule doesn't kill CC - #684

Open
offamitkumar wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-offamitkumar-857df837-master
Open

8388439: [s390x] LoadNKlass rule doesn't kill CC#684
offamitkumar wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-offamitkumar-857df837-master

Conversation

@offamitkumar

@offamitkumar offamitkumar commented Jul 30, 2026

Copy link
Copy Markdown
Member

Hi all,

This pull request contains a backport of commit 857df837 from the openjdk/jdk repository.

effect(KILL cr); for the rule loadNKlassCompactHeaders is wrong. it uses two instruction lg + srlg both of which are not killing CC according to Z operations book.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8388439 needs maintainer approval

Issue

  • JDK-8388439: [s390x] LoadNKlass rule doesn't kill CC (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/684/head:pull/684
$ git checkout pull/684

Update a local copy of the PR:
$ git checkout pull/684
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 684

View PR using the GUI difftool:
$ git pr show -t 684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/684.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 30, 2026

Copy link
Copy Markdown

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 30, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@offamitkumar
offamitkumar marked this pull request as ready for review July 30, 2026 07:12
@openjdk openjdk Bot changed the title Backport 857df83728c098fdf057ecef2f60e0f295bae352 8388439: [s390x] LoadNKlass rule doesn't kill CC Jul 30, 2026
@openjdk

openjdk Bot commented Jul 30, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 30, 2026
@openjdk

openjdk Bot commented Jul 30, 2026

Copy link
Copy Markdown

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 30, 2026
@mlbridge

mlbridge Bot commented Jul 30, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant