Skip to content

8388412: Update PKCS#11 Cryptographic Token Interface to v3.2 - #680

Open
chmielewskiandreas wants to merge 1 commit into
openjdk:masterfrom
chmielewskiandreas:JDK-8388412
Open

8388412: Update PKCS#11 Cryptographic Token Interface to v3.2#680
chmielewskiandreas wants to merge 1 commit into
openjdk:masterfrom
chmielewskiandreas:JDK-8388412

Conversation

@chmielewskiandreas

@chmielewskiandreas chmielewskiandreas commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Hi, this is a clean backport of 7e28af20ee76808d66ac5ce4d254539bac5c8e72

While updating the PKCS#11 headers from v3.1 to v3.2, I copied the files from the upstream specification repository.
Unfortunately, the upstream versions of the following files contain tab characters in some of the newer additions:

src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h
src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11f.h

git pr create --jcheck reported whitespace violations for these tabs.
To make it pass, I replaced the tabs with (4) spaces.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8388412 needs maintainer approval

Issue

  • JDK-8388412: Update PKCS#11 Cryptographic Token Interface to v3.2 (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/680/head:pull/680
$ git checkout pull/680

Update a local copy of the PR:
$ git checkout pull/680
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/680/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 680

View PR using the GUI difftool:
$ git pr show -t 680

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/680.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 28, 2026

Copy link
Copy Markdown

👋 Welcome back achmielewski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 28, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 7e28af20ee76808d66ac5ce4d254539bac5c8e72 8388412: Update PKCS#11 Cryptographic Token Interface to v3.2 Jul 28, 2026
@openjdk

openjdk Bot commented Jul 28, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 28, 2026
@chmielewskiandreas
chmielewskiandreas marked this pull request as ready for review July 30, 2026 13:33
@openjdk

openjdk Bot commented Jul 30, 2026

Copy link
Copy Markdown

⚠️ @chmielewskiandreas This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 30, 2026
@mlbridge

mlbridge Bot commented Jul 30, 2026

Copy link
Copy Markdown

Webrevs

@chmielewskiandreas

chmielewskiandreas commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

/approval request

This backport is low/none risk. It only updates the PKCS#11 header files by adding constants and definitions. No functional code changes are included.

The resulting changes can be reviewed with:
git diff --word-diff -w origin/master -- src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11f.h src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11.h

No additional testing was performed beyond the usual CI testing. The Extended Master Secret related definitions introduced by this backport are exercised and verified by JDK-8389137

@openjdk

openjdk Bot commented Jul 31, 2026

Copy link
Copy Markdown

@chmielewskiandreas
8388412: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant