8388412: Update PKCS#11 Cryptographic Token Interface to v3.2 - #680
8388412: Update PKCS#11 Cryptographic Token Interface to v3.2#680chmielewskiandreas wants to merge 1 commit into
Conversation
|
👋 Welcome back achmielewski! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request This backport is low/none risk. It only updates the PKCS#11 header files by adding constants and definitions. No functional code changes are included. The resulting changes can be reviewed with: No additional testing was performed beyond the usual CI testing. The Extended Master Secret related definitions introduced by this backport are exercised and verified by JDK-8389137 |
|
@chmielewskiandreas |
Hi, this is a clean backport of 7e28af20ee76808d66ac5ce4d254539bac5c8e72
While updating the PKCS#11 headers from v3.1 to v3.2, I copied the files from the upstream specification repository.
Unfortunately, the upstream versions of the following files contain tab characters in some of the newer additions:
src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11t.h
src/jdk.crypto.cryptoki/share/native/libj2pkcs11/pkcs11f.h
git pr create --jcheck reported whitespace violations for these tabs.
To make it pass, I replaced the tabs with (4) spaces.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/680/head:pull/680$ git checkout pull/680Update a local copy of the PR:
$ git checkout pull/680$ git pull https://git.openjdk.org/jdk25u-dev.git pull/680/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 680View PR using the GUI difftool:
$ git pr show -t 680Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/680.diff
Using Webrev
Link to Webrev Comment