7067310: 3 tests from closed/javax/sound/sampled caused BSOD on win 7 x86 - #678
7067310: 3 tests from closed/javax/sound/sampled caused BSOD on win 7 x86#678rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issues from the original commit. |
|
|
|
/approval request for backport of JDK-7067310, JDK-8307574, and JDK-8308395. This is a problem list update. For parity with Oracle JDK. |
Backporting JDK-7067310, JDK-8307574, and JDK-8308395: tests from closed/javax/sound/sampled caused BSOD on win 7 x86, ClipIsRunningAfterStop.java failed with "../nptl/pthread_mutex_lock.c:81: __pthread_mutex_lock: Assertion `mutex->__data.__owner == 0' failed.", and javax/sound/sampled/Clip/ClipFlushCrash.java timed out
This PR removes several sound tests from the problem list.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, and macos-aarch64:
make test TEST="test/jdk/javax/sound/sampled/DirectAudio/bug6372428.java test/jdk/javax/sound/sampled/Clip/bug5070081.java test/jdk/javax/sound/sampled/DataLine/LongFramePosition.java test/jdk/javax/sound/sampled/Mixers/DisabledAssertionCrash.java test/jdk/javax/sound/midi/Sequencer/Recording.java test/jdk/javax/sound/midi/Sequencer/Looping.java test/jdk/javax/sound/sampled/Clip/ClipIsRunningAfterStop.java test/jdk/javax/sound/sampled/Clip/ClipFlushCrash.java"
Results:
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Ran related tests on windows-x64:
make test TEST=test/jdk/javax/sound/sampled/DirectAudio/bug6372428.java
make test TEST=test/jdk/javax/sound/sampled/Clip/bug5070081.java
make test TEST=test/jdk/javax/sound/sampled/DataLine/LongFramePosition.java
make test TEST=test/jdk/javax/sound/sampled/Mixers/DisabledAssertionCrash.java
make test TEST=test/jdk/javax/sound/midi/Sequencer/Recording.java
make test TEST=test/jdk/javax/sound/midi/Sequencer/Looping.java
make test TEST=test/jdk/javax/sound/sampled/Clip/ClipIsRunningAfterStop.java
make test TEST=test/jdk/javax/sound/sampled/Clip/ClipFlushCrash.java
Results:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
windows-x64-specific-3-test.log
windows-x64-specific-4-test.log
windows-x64-specific-5-test.log
windows-x64-specific-6-test.log
windows-x64-specific-7-test.log
windows-x64-specific-8-test.log
Please note that I also ran "../jtreg/build/images/jtreg/bin/jtreg -jdk build/*/images/jdk test/jdk/javax/sound/midi/Sequencer/Looping.java" on windows-x64 and it passed.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/678/head:pull/678$ git checkout pull/678Update a local copy of the PR:
$ git checkout pull/678$ git pull https://git.openjdk.org/jdk25u-dev.git pull/678/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 678View PR using the GUI difftool:
$ git pr show -t 678Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/678.diff
Using Webrev
Link to Webrev Comment