8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) - #669
8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1)#669rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1). This PR adds PBMAC1 support to PKCS12 keystore. For parity with Oracle JDK. Medium Risk — the change touches security-sensitive code paths, but includes dedicated tests. |
Backporting JDK-8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1).
This PR add PKCS#12 KeyStore support for Password-Based Message Authentication Code 1 (PBMAC1).
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/sun/security/pkcs12
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/669/head:pull/669$ git checkout pull/669Update a local copy of the PR:
$ git checkout pull/669$ git pull https://git.openjdk.org/jdk25u-dev.git pull/669/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 669View PR using the GUI difftool:
$ git pr show -t 669Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/669.diff
Using Webrev
Link to Webrev Comment