Skip to content

8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) - #669

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8343232-V25
Open

8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1)#669
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8343232-V25

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1).

This PR add PKCS#12 KeyStore support for Password-Based Message Authentication Code 1 (PBMAC1).

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/sun/security/pkcs12

Results:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343232 needs maintainer approval
  • Change requires CSR request JDK-8370042 to be approved

Issues

  • JDK-8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) (Enhancement - P2 - Approved)
  • JDK-8370042: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/669/head:pull/669
$ git checkout pull/669

Update a local copy of the PR:
$ git checkout pull/669
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/669/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 669

View PR using the GUI difftool:
$ git pr show -t 669

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/669.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review July 16, 2026 16:15
@bridgekeeper

bridgekeeper Bot commented Jul 16, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport 1781b186b51900b758dd55cc356eaaf12b28481b 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1) Jul 16, 2026
@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 16, 2026
@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 16, 2026
@mlbridge

mlbridge Bot commented Jul 16, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1).

This PR adds PBMAC1 support to PKCS12 keystore.

For parity with Oracle JDK.

Medium Risk — the change touches security-sensitive code paths, but includes dedicated tests.

@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

@rm-gh-8
8343232: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jul 16, 2026
@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant