Skip to content

8386600: Fix comparison checks in DHasKEM - #667

Open
rm-gh-8 wants to merge 1 commit into
openjdk:pr/665from
rm-gh-8:JDK-8386600-V25
Open

8386600: Fix comparison checks in DHasKEM#667
rm-gh-8 wants to merge 1 commit into
openjdk:pr/665from
rm-gh-8:JDK-8386600-V25

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8386600: Fix comparison checks in DHasKEM.

This PR fixes the X25519/X448 all-zero shared secret validation in DHasKEM.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/javax/net/ssl
make test TEST=test/jdk/sun/security

Results:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8386600 needs maintainer approval

Integration blocker

 ⚠️ Dependency #665 must be integrated first

Issue

  • JDK-8386600: Fix comparison checks in DHasKEM (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/667/head:pull/667
$ git checkout pull/667

Update a local copy of the PR:
$ git checkout pull/667
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/667/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 667

View PR using the GUI difftool:
$ git pr show -t 667

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/667.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review July 16, 2026 13:14
@bridgekeeper

bridgekeeper Bot commented Jul 16, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into pr/665 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 95be3f95205e386ead5286872ac5875c9ca0801c 8386600: Fix comparison checks in DHasKEM Jul 16, 2026
@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 16, 2026
@mlbridge

mlbridge Bot commented Jul 16, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8386600: Fix comparison checks in DHasKEM.

This PR fixes the X25519/X448 all-zero shared secret validation in DHasKEM.

For parity with Oracle JDK.

Low Risk — the change fixes a dead condition, but since the all-zero check never executed before, there is no risk of regression to existing handshake behavior.

@openjdk

openjdk Bot commented Jul 16, 2026

Copy link
Copy Markdown

@rm-gh-8
8386600: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant