You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into pr/665 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
This backport pull request has now been updated with issue from the original commit.
openjdkBot
added
backport
Port of a pull request already in a different code base
clean
Identical backport; no merge resolution required
rfr
Pull request is ready for review
labels
Jul 16, 2026
/approval request for backport of JDK-8386600: Fix comparison checks in DHasKEM.
This PR fixes the X25519/X448 all-zero shared secret validation in DHasKEM.
For parity with Oracle JDK.
Low Risk — the change fixes a dead condition, but since the all-zero check never executed before, there is no risk of regression to existing handshake behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvalRequires approval; will be removed when approval is receivedbackportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredrfrPull request is ready for review
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8386600: Fix comparison checks in DHasKEM.
This PR fixes the X25519/X448 all-zero shared secret validation in DHasKEM.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/javax/net/ssl
make test TEST=test/jdk/sun/security
Results:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/667/head:pull/667$ git checkout pull/667Update a local copy of the PR:
$ git checkout pull/667$ git pull https://git.openjdk.org/jdk25u-dev.git pull/667/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 667View PR using the GUI difftool:
$ git pr show -t 667Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/667.diff
Using Webrev
Link to Webrev Comment