feat(qwen35): add transactional speculative verifier#667
Open
CAICAIIs wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Follow-up split plan:
Each PR will keep the default Qwen3.5 path unchanged unless DFlash is enabled. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c65ada7ecd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
CAICAIIs
marked this pull request as draft
July 13, 2026 13:19
CAICAIIs
marked this pull request as ready for review
July 14, 2026 01:42
CAICAIIs
force-pushed
the
feat/qwen35-speculative-verifier
branch
from
July 16, 2026 18:31
c3470ad to
53581b1
Compare
Signed-off-by: CAICAIIs <3360776475@qq.com>
CAICAIIs
force-pushed
the
feat/qwen35-speculative-verifier
branch
from
July 18, 2026 05:53
53581b1 to
06cde7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the target-verifier slice split out of #626. It makes Qwen3.5 speculative verification reviewable independently from the draft model and serving integration.
It verifies
[current token, draft tokens...]in one target forward pass, then commits the longest greedy-matching prefix plus one target token. Qwen3.5 hybrid state is handled as one transaction: paged KV, recurrent state, convolution state, and CUDA Graph slot state.What changed
Validation
On one RTX 5090 with Qwen3.5-4B:
Scope
This PR does not add the DFlash draft model, scheduler/server opt-in wiring, sampling support, or a performance claim. Those parts remain in follow-up PRs split from #626.