Skip to content

Clarify an empty object in a VP Token cannot be used to signify an error response#745

Draft
awoie wants to merge 1 commit into
mainfrom
awoie/fix-743
Draft

Clarify an empty object in a VP Token cannot be used to signify an error response#745
awoie wants to merge 1 commit into
mainfrom
awoie/fix-743

Conversation

@awoie

@awoie awoie commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixes #743

  • needs errata? change 1.0?

I also improved the vp_token definition because it is a quite important part of the spec and the readability was not great.

I removed this editorially because I don't think it had any meaning anymore:

The same rules as above apply for encoding the Presentations.

@awoie awoie marked this pull request as draft June 18, 2026 17:31
@awoie

awoie commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

We probably will need to apply this logic to DC API as well. I will need to double check if this is included with the current proposed text.

@fkj fkj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If people don't object to the rewriting of the definition, I agree that this makes it easier to understand what we actually mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify error case when wallet returns empty vp_token vs error response vs no response

2 participants