Fix: Haxe 5 compatibility (bump Haxe version from 4.3.6 to 4.3.7 + remove the old hxcpp compile cache when rebuilding Linux ARM ndlls)#2068
Open
MRK2009 wants to merge 8 commits into
Open
Conversation
MRK2009
changed the title
MRK2009
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, It looks like Haxe 5 broke lime because some of the methods got removed from
MainLoopclass (includingprogressfrom theThreadclass).So I had to fix it by using a wrapper of
MainLoopclass and useloopOnceto make it work.I tested it on C++ targets and it looks like it works fine(except it giving me warnings still)
But I'm not sure how to fix the errors for Flash and AIR targets though.