Performance: cache paramsQl for HYBRID KeySwitchDown#1185
Merged
Conversation
Collaborator
Author
|
( |
Contributor
Are you saying you saw an error when running this unit test? If yes, please create an issue and copy the error output there. |
Contributor
|
Oh. I see the output. Let me rerun the CI. |
yspolyakov
force-pushed
the
perf/cache-paramsql-clean
branch
from
May 28, 2026 02:52
1563cf9 to
83c06e2
Compare
yspolyakov
approved these changes
May 28, 2026
dsuponitskiy
force-pushed
the
perf/cache-paramsql-clean
branch
2 times, most recently
from
May 28, 2026 23:09
1e419fd to
0fe8599
Compare
dsuponitskiy
force-pushed
the
perf/cache-paramsql-clean
branch
from
June 2, 2026 19:16
97186d1 to
baaaf8c
Compare
pascoec
self-requested a review
June 2, 2026 20:01
pascoec
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the TODO in
keyswitch-hybrid.cppby avoiding repeatedparamsQlconstruction in the HYBRID keyswitch path.Changes
m_paramsQlHybridinCryptoParametersRNS::PrecomputeCRTTables()for the first1..sizeQtowers of Q when HYBRID key switching is used.GetParamsQlHybrid(sizeQl)inrns-cryptoparameters.h.KeySwitchDown()andKeySwitchDownFirstElement()instead of rebuildingILDCRTParamson each call.Notes