Some function refactoring - #55
Merged
Merged
Conversation
Improve error messages related to sensor updates. Fix check in EngineRate (ramp != 1 instead of ramp == 1). Let function SensorRate return 1.0 also for control out sensors. Change to intent(in) on some evaluation subroutines/functions.
kmokstad
force-pushed
the
function-update
branch
3 times, most recently
from
June 30, 2026 03:47
6e60159 to
320f29a
Compare
kmokstad
force-pushed
the
function-update
branch
from
August 1, 2026 06:14
320f29a to
81c710f
Compare
Add subroutine copyCtrl().
to function argument sensors are set up before accessing them
simplicity. Using argSensor only which is gradually enlarged in the case multi-argument functions are present.
Remove WriteSysMat2 - use WriteSysMat with complexity > 10 instead. Add option to write out the sparse matrix as full, regardless of its size.
with a pointer to an engine object which is used if the sensor is measuring another Function. With this it is easier to traverse the function-argument chain recursively and we don't need the global copy of the engines array in engineRoutinesModule. The updateSensor() subroutine can now also be made private to engineRoutinesModule.
Remove never used (or not for a very long time) SensorType member in the CtrlPrm type to simplify some logic.
…library to avoid dependency issues on Linux when building as static libraries
kmokstad
force-pushed
the
function-update
branch
from
August 2, 2026 10:09
81c710f to
d0d3cfb
Compare
is specified in one of the option files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup/refactor of the engine/function/sensor processing, in preparation for upcoming coupled control system and structure modal analysis implementation.