Conversation
Put static functions into anonymous namespace in testModels.C.
frictionRoutinesModule.f90 and initiateFrictioniTypeModule.f90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through the submodule update, external nodes with beam end release are now not allowed and flagged as modelling error.
If the only element connected to an external node is a beam element with end release (beam pin flags), the model reduction will fail with singularities as some of the external DOFs then will have no stiffness contribution. This was seen in the BeamPin1 regression test of the fedem-solvers repository, which therefore is updated such that it will pass with the change.
Also some more solver doxy.