FFlVisualization cleaning - #51
Merged
Merged
Conversation
…ke option. Add variable BUILD_FOUNDATION_TESTS to signal the test build and execution. Add variable USE_FORTRAN_INTERFACE in the CMakeLists.txt file of FFlLib. Build FFlLinkHandler_F.C in a separate library to simplify dependencies.
Add FFlVisEdge::getVertexIdx() and FFlVisEdgeRef::get[First|Second]VxIdx(). Add check for null pointer before dereferencing them.
new methods for positive and negative face directions, respectively.
Use a lambda for repetitive tasks in FFlVisFace::getElmFaceVertices(). Use array indices in the functor FFlVisFace::FFlVisFaceLess to avoid the need for the static iterator variables. Let FFlVisFace::setFaceVertices() return false if degenerated face.
FFlGroupPartCreator::joinFacesFromEdge() using FFlVisFace::nextEdge()
Remove the isIndexShape member - check shapeIndexes.empty() instead. Add begin() and end() for iterating over the myLinkParts map.
Remove reference to vertex container as member, using myWorkLink->getVertexes() instead when needed. Move method setEdgeGeomStatus() to class FFlVisFace.
with the only use being inside the other relation operators. The functor FFlVisEdgeEqual is then no longer needed. Replace FFlVisEdgeRef::getEdge() by FFlVisEdgeRef::sameAs(), which only compares the FFlVisEdge pointer members. Use std::find_if() with a lambda when searching for matching edge in neighboring faces in FFlGroupPartCreator::joinFacesFromEdge().
Some of the private methods are moved into anonymous namespace in the implementation file while others are reimplemented as lambdas. The unused method isLinesIntersecting() is removed completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify some logic and data structures - no intended functionality change.
See commit log for details.
Includes #50.