feanil/fix ltistore filter config - #43
Merged
Merged
Conversation
feanil
commented
Sep 9, 2025
feanil
commented
Contributor
- fix: Don't copy the settings twice.
- fix: Simplify and better safeguard settings patch.
Since we want this setting in both the LMS and CMS, just make them in the openedx-common-settings patch instead of having two copies.
Handle the case where the OPEN_EDX_FILTERS_CONFIG setting might not exist and simplify the code for adding/updating the new step to the correct pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.