feat: enhance translation script (i18n) with custom translations#663
feat: enhance translation script (i18n) with custom translations#663RawanMatar89 wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @RawanMatar89! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Summary:
The localization script has been updated to scan for a specific file named CustomLocalizable.strings within the .lproj directories of the app modules.
Merging Strategy:
Priority Logic: Keys defined in CustomLocalizable.strings take precedence. If a key exists in both files, the custom value overwrites the default value in the final output.
Changes:
Screenshots:
why?
It keeps custom changes separate from core changes, making it easier to pull upstream updates from Open edX without merge conflicts in .strings files.
Testing:
Verified that the script completes successfully even if a module has no CustomLocalizable.strings file.
Verified the --split and --combine commands.
Jira link:
https://zeitlabs.atlassian.net/browse/CC-18