Skip to content

fix: typo in translation.py inline comments #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RawanMatar89 wants to merge 1 commit into from
Closed

fix: typo in translation.py inline comments #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions i18n_scripts/translation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def parse_arguments():
@contextmanager
def change_directory(new_dir: Path):
"""
Context manager to execute `os.chidir`.
Context manager to execute `os.chdir`.

Usage:

Expand All @@ -69,7 +69,7 @@ def change_directory(new_dir: Path):

def get_modules_dir(override: Path = None) -> Path:
"""
Gets the modeles directory (repository root directory).
Gets the modules directory (repository root directory).
"""
if override:
return override
Expand Down Expand Up @@ -109,13 +109,13 @@ def get_translation_file_path(modules_dir: Path, module_name, lang_dir, create_d

def get_modules_to_translate(modules_dir: Path):
"""
Retrieve the names of modules that have translation files for a specified language.
Retrieve the names of modules that have translation files for the English language.

Parameters:
modules_dir (Path): The path to the directory containing all the modules.

Returns:
list of str: A list of module names that have translation files for the specified language.
list of str: A list of module names that have English translation files.
"""
try:
modules_list = [
Expand Down Expand Up @@ -407,7 +407,7 @@ def add_localizable(xcode_project: XcodeProject, localizable_relative_path: Path

def add_translation_files_to_xcode(modules_dir: Path = None):
"""
Add Localizable.strings files pulled from Transifex to XCode.
Add Localizable.strings files pulled from Transifex (or split from I18N) to XCode projects.
"""
try:
modules_dir = get_modules_dir(override=modules_dir)
Expand Down
Loading