chore: fix integrations tests - #239
Conversation
|
Thanks for the pull request, @Henrrypg! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
/integration-test |
|
/integration-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 95.32% 95.32% -0.01%
==========================================
Files 69 69
Lines 8090 8089 -1
Branches 432 432
==========================================
- Hits 7712 7711 -1
Misses 283 283
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
felipemontoya
left a comment
There was a problem hiding this comment.
This looks good to me. It also looks good to the integration tests ;)
Fix stale-thread recovery not triggering for OpenAI Responses API
LLMProcessor._call_responses_wrapper catches BadRequestError and checks e.code to detect an expired previous_response_id (previous_response_not_found) so it can clear the stale ID and retry with full history. In practice e.code is unreliable — litellm/openai's exception wiring doesn't consistently populate it across call paths and litellm versions, so the real error code only reliably shows up in the exception message (str(e)).
This caused test_stale_thread_id_triggers_recovery and test_conversation_clean_after_stale_thread_recovery to fail in CI