Skip to content

chore: fix integrations tests - #239

Merged
Henrrypg merged 2 commits into
openedx:mainfrom
eduNEXT:hpg/fix-integrations-tests
Jun 25, 2026
Merged

chore: fix integrations tests#239
Henrrypg merged 2 commits into
openedx:mainfrom
eduNEXT:hpg/fix-integrations-tests

Conversation

@Henrrypg

@Henrrypg Henrrypg commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Fix stale-thread recovery not triggering for OpenAI Responses API

LLMProcessor._call_responses_wrapper catches BadRequestError and checks e.code to detect an expired previous_response_id (previous_response_not_found) so it can clear the stale ID and retry with full history. In practice e.code is unreliable — litellm/openai's exception wiring doesn't consistently populate it across call paths and litellm versions, so the real error code only reliably shows up in the exception message (str(e)).

This caused test_stale_thread_id_triggers_recovery and test_conversation_clean_after_stale_thread_recovery to fail in CI

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 25, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Henrrypg!

This repository is currently maintained by @felipemontoya.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Henrrypg

Copy link
Copy Markdown
Contributor Author

/integration-test

@Henrrypg

Copy link
Copy Markdown
Contributor Author

/integration-test

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.32%. Comparing base (1bc8eb6) to head (a32405e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   95.32%   95.32%   -0.01%     
==========================================
  Files          69       69              
  Lines        8090     8089       -1     
  Branches      432      432              
==========================================
- Hits         7712     7711       -1     
  Misses        283      283              
  Partials       95       95              
Flag Coverage Δ
unittests 95.32% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Henrrypg
Henrrypg requested a review from felipemontoya June 25, 2026 14:58

@felipemontoya felipemontoya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It also looks good to the integration tests ;)

@Henrrypg
Henrrypg merged commit adb1c3f into openedx:main Jun 25, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants