Skip to content

fix: navigation sidebar scrolling on mobile devices#1927

Open
Agrendalath wants to merge 1 commit into
openedx:masterfrom
open-craft:agrendalath/fix-mobile-navigation-sidebar
Open

fix: navigation sidebar scrolling on mobile devices#1927
Agrendalath wants to merge 1 commit into
openedx:masterfrom
open-craft:agrendalath/fix-mobile-navigation-sidebar

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Jun 15, 2026

Copy link
Copy Markdown
Member

This fixes the following issues with the navigation sidebar on mobile devices:

  1. The sidebar on mobile devices was automatically closed when scrolling down due to the browser's resize event when hiding the URL bar.
  2. The sidebar was not displayed as full-screen because the position from Bootstrap's fixed-top utility class was overridden by the position: relative rule for the .outline-sidebar-wrapper selector.
  3. The full-screen sidebar could not be scrolled due to the lack of vertical overflow.

Testing instructions

Check the use cases described above with the narrow viewport.

Deadline

"None"

Other information

Private-ref: BB-7413

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Agrendalath!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 15, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 15, 2026
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.31%. Comparing base (87d9f1a) to head (4b1f255).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...re/course/sidebar/sidebars/course-outline/hooks.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1927      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.01%     
==========================================
  Files         346      346              
  Lines        5789     5794       +5     
  Branches     1389     1353      -36     
==========================================
+ Hits         5287     5291       +4     
- Misses        483      484       +1     
  Partials       19       19              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants