feat: raise descriptive error when proctoring provider cannot remove an attempt - #1337
feat: raise descriptive error when proctoring provider cannot remove an attempt#1337Anas12091101 wants to merge 4 commits into
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description:
Makes proctored-exam attempt removal fail loudly and clearly when the proctoring provider errors, instead of hanging, returning an unhandled 500 (which rolled back the local delete), or silently doing a local-only reset.
timeoutinPROCTORING_BACKENDS.pre_deletehandler logs it and raises a typedBackendProviderCannotRemoveAttempt(HTTP 502) instead of a 500; the local delete is aborted so the attempt is preserved.raise_on_remove_errorinPROCTORING_BACKENDS.external_id) are unchanged — reset still proceeds.Tests cover the timeout (default + configurable), the unreachable and provider-error paths (with/without body, and the opt-out), and preserving the provider message vs. the generic one.
Pre-Merge Checklist:
edx_proctoring/__init__.pyandpackage.jsonif these changes are to be released.CHANGELOG.rstPost-Merge: