Skip to content

Fix getStackTop on LLVM older than 18. #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdruppe merged 1 commit into from
Jul 14, 2026
+17 −5
Merged

Fix getStackTop on LLVM older than 18. #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions druntime/src/core/thread/osthread.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1745,10 +1745,7 @@ in (fn)
//
// Spilling has to be done somehow else.

import ldc.intrinsics;

static if (LLVM_atleast!22) sp = llvm_stackaddress();
else sp = llvm_stacksave();
sp = getStackTop();
}
else version (FreeStanding) {
assert(0);
Expand Down Expand Up @@ -1864,7 +1861,22 @@ version (LDC)
import ldc.intrinsics;

static if (LLVM_atleast!22) return llvm_stackaddress();
else return llvm_stacksave();
else static if (LLVM_atleast!18) return llvm_stacksave();
else {
// Inline assembly to workaround issue solved by
// https://github.com/llvm/llvm-project/pull/68133
//
// Which wasn't merged/fixed until LLVM 18

import ldc.llvmasm;

enum string isize = size_t.sizeof == 8 ? "i64" : "i32";
return __asm!(void*)(`
.globaltype __stack_pointer, `~isize~`
global.get __stack_pointer
local.set $0
`, "=r");
}
}
}
else
Expand Down