Skip to content

chore(all): update dependency setuptools to v84 [SECURITY] - autoclosed - #127

Closed
renovate-bot wants to merge 1 commit into
openconfig:masterfrom
renovate-bot:renovate/pypi-setuptools-vulnerability
Closed

renovate-bot wants to merge 1 commit into
openconfig:masterfrom
renovate-bot:renovate/pypi-setuptools-vulnerability

Conversation

@renovate-bot

@renovate-bot renovate-bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
setuptools (changelog) <82 → <85 age confidence

setuptools: MANIFEST.in exclusion bypass in sdist via Unicode normalization collision (NFC/NFD) on macOS APFS/HFS+

CVE-2026-59890 / GHSA-h35f-9h28-mq5c

More information

Details

Summary

When building a source distribution (python -m build --sdist / setup.py sdist), setuptools' FileList applies MANIFEST.in directives (exclude, global-exclude, recursive-exclude, prune) by matching a compiled glob against on-disk file names byte-for-byte, with no Unicode normalization. On normalization-preserving filesystems (notably macOS APFS and HFS+), a file written in NFD and a MANIFEST.in rule written in NFC refer to the same file but are byte-distinct, so the exclusion silently fails to match. A file the maintainer intended to exclude is then packed into the .tar.gz and, if published, uploaded to the public, immutable PyPI index.

Details

File names in FileList.files come from os.walk (setuptools/_distutils/filelist.py, _find_all_simple), so on APFS a file written NFD is offered to the matcher in NFD, while the MANIFEST.in pattern carries the author's editor form (typically NFC). The matching path performs no canonicalization:

##### setuptools/command/egg_info.py  (FileList.global_exclude)
def global_exclude(self, pattern):
    match = translate_pattern(os.path.join('**', pattern))   # fnmatch.translate -> regex, no NFC/NFD
    return self._remove_files(match.match)                   # byte-level regex over raw os.walk names

A rule written NFC (café = 63 61 66 c3 a9) does not match an on-disk name written NFD (café = 63 61 66 65 cc 81), even though the filesystem treats the two as one file.

A unicodedata.normalize('NFD', ...) helper exists in setuptools/unicode_utils.py (decompose()), but it is never called in the manifest matching path, so neither the pattern nor the walked path is normalized before matching. The only normalization in this area, EggInfoCommand._manifest_normalize, uses filesys_decode (bytes→str decode only, no NFC/NFD) and runs when writing SOURCES.txt, after matching has already occurred.

Impact

MANIFEST.in exclusions are the documented mechanism maintainers use to keep secrets, local configs, and private fixtures out of the published sdist. A non-ASCII excluded file may be published to the public, immutable PyPI index despite the rule — an irreversible disclosure with no visual cue (NFC and NFD forms render identically). Exposure is filesystem-dependent and most relevant on macOS APFS/HFS+, where many maintainers build and publish. Pure-ASCII rules are unaffected.

Proof of concept

With a project containing MANIFEST.in:

global-include *.txt *.json
global-exclude secret_café.txt    # rule saved NFC

and an on-disk file secret_café.txt written in NFD, python -m build --sdist packs the secret file into the resulting .tar.gz, while an ASCII control file excluded by the same directive is correctly dropped — isolating the bypass to the NFC-pattern vs. NFD-name mismatch. Reproduced on macOS APFS with setuptools 82.0.1.

Remediation

Normalize both the walked path and each MANIFEST.in pattern to a single canonical form before matching, in both setuptools/command/egg_info.py (FileList) and the vendored setuptools/_distutils/filelist.py. For an exclusion list, err toward excluding more, and document that MANIFEST.in matching is normalization-insensitive on macOS.

Credit

Reported by Tomas Illuminati. Coordinated via CERT/CC VINCE VU#604762.

Severity

  • CVSS Score: 6.1 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:L/AC:L/PR:N/UI:R/S:U/C:H/I:L/A:N

References

This data is provided by the GitHub Advisory Database (CC-BY 4.0).


Release Notes

pypa/setuptools (setuptools)

v84.2.0

Compare Source

v84.1.0

Compare Source

v84.0.0

Compare Source

v83.0.0

Compare Source

v82.0.1

Compare Source

v82.0.0

Compare Source


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 4d52c81 to 3e041d6 Compare September 3, 2026 01:13
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 3, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 3, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from 8e08bca to 9787e2f Compare September 4, 2026 02:36
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 4, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 8, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from a216a66 to 5dfff4c Compare September 8, 2026 05:10
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 8, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 10, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from dc3e3c0 to bf3c94e Compare September 11, 2026 02:55
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 11, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 15, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from f3bf140 to b00b9c8 Compare September 16, 2026 01:29
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 16, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 16, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from a3cbfad to 8790ddb Compare September 16, 2026 22:23
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 16, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 17, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from fbc3508 to 9e5a697 Compare September 18, 2026 00:08
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 18, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 18, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from af7d9ec to 34931ff Compare September 19, 2026 01:58
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 19, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 23, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from dd95bf6 to 1f50206 Compare September 24, 2026 05:58
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Sep 24, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Sep 30, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from 0629bd0 to 2751d66 Compare October 1, 2026 16:10
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Oct 1, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Oct 5, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch 2 times, most recently from b0f94fb to 0baf7f7 Compare October 5, 2026 23:04
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v83 [SECURITY] Oct 5, 2026
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v83 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] Oct 13, 2026
@renovate-bot
renovate-bot force-pushed the renovate/pypi-setuptools-vulnerability branch from 0baf7f7 to ea9df51 Compare October 13, 2026 15:54
@renovate-bot renovate-bot changed the title chore(all): update dependency setuptools to v84 [SECURITY] chore(all): update dependency setuptools to v84 [SECURITY] - autoclosed Oct 21, 2026
@renovate-bot
renovate-bot deleted the renovate/pypi-setuptools-vulnerability branch October 21, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant