Repository navigation
gRIBI aft v3.5.0 - #119
gRIBI aft v3.5.0#119dplore wants to merge 8 commits into
Conversation
nandanarista
left a comment
There was a problem hiding this comment.
hi darren, thank you for taking care of this!
since backupActivation is a new top level AFT, i think we also need to update gribi.proto with the new enums and pointers in the request and get response
ie,
-
entryunion (ModifyRequest)gribi/v1/proto/service/gribi.proto
Line 191 in 69e0fb2
-
AFTTypeenumgribi/v1/proto/service/gribi.proto
Line 428 in 69e0fb2
-
AFTEntry (part of GetResponse)
gribi/v1/proto/service/gribi.proto
Line 467 in 69e0fb2
if you were planning to add these in a separate PR, that is fine too
thanks!
Thanks for pointing this out, updated gribi.proto with the backup_activate fields. |
nandanarista
left a comment
There was a problem hiding this comment.
hi darren, looks great; please regen the gobindings and we should be good to go
nandanarista
left a comment
There was a problem hiding this comment.
lgtm, thank you again!
|
Questions about BackupActivation - [1] What is the expected AFTResult of Modify response if the target NHG does not have a backup NHG ? Should the entry to accepted with FIB_PROGRAMMED/RIB_PROGRAMMED (per ACK mode) or rejected with FIB_FAILED ? [2] Same question as above for the case where the target NHG has a backup NHG but all the backup NHs are down or nonviable ? [3] Assuming backup NHG is in activated state. What is the expected behavor when all the backup nexthops go down or become nonviable? Should traffic be kept on the backup nexthops as expected, or switched back to viable primary nexthop(s) ? |
…ks for this release
|
Deviate unsupported decap-mpls-label-stacks and encap-mpls-label-stacks for this release. These leaves may be added when there is a specific use for them in the future. |
This pull request updates the gRIBI AFT (Abstract Forwarding Table) protobuf and Go module dependencies to extend the AFT schema for backup activation support.
Protocol Buffer Schema Extensions:
BackupActivationmessage to theAftsmessage ingribi_aft.proto, supporting backup activation tracking per next-hop group.Generated Go Code:
enums.pb.gowith a newer version ofprotoc-gen-go,Dependency Updates:
ygot,grpc,protobuf, and added new indirect dependencies)