Skip to content

gRIBI aft v3.5.0 - #119

Open
dplore wants to merge 8 commits into
masterfrom
dplore/aft-3.5.0
Open

dplore wants to merge 8 commits into
masterfrom
dplore/aft-3.5.0

Conversation

@dplore

@dplore dplore commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

This pull request updates the gRIBI AFT (Abstract Forwarding Table) protobuf and Go module dependencies to extend the AFT schema for backup activation support.

Protocol Buffer Schema Extensions:

  • Introduced BackupActivation message to the Afts message in gribi_aft.proto, supporting backup activation tracking per next-hop group.

Generated Go Code:

  • Regenerated enums.pb.go with a newer version of protoc-gen-go,

Dependency Updates:

  • Updated the Go module to require Go 1.26 and upgraded dependencies (ygot, grpc, protobuf, and added new indirect dependencies)

@dplore
dplore marked this pull request as ready for review October 7, 2026 01:21

@nandanarista nandanarista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi darren, thank you for taking care of this!

since backupActivation is a new top level AFT, i think we also need to update gribi.proto with the new enums and pointers in the request and get response

ie,

if you were planning to add these in a separate PR, that is fine too
thanks!

@dplore

dplore commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

backupActivation

Thanks for pointing this out, updated gribi.proto with the backup_activate fields.

Comment thread v1/proto/service/gribi.proto
Comment thread v1/proto/service/gribi.proto Outdated

@nandanarista nandanarista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi darren, looks great; please regen the gobindings and we should be good to go

Comment thread v1/proto/service/gribi.pb.go

@aayueshbarui aayueshbarui left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nandanarista nandanarista left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you again!

Comment thread v1/proto/gribi_aft/gribi_aft.proto Outdated
Comment thread v1/proto/service/gribi.proto
Comment thread v1/yang/aft/openconfig-aft-ethernet.yang
@dplore
dplore requested a review from robshakir October 8, 2026 17:16
@yiminshen49

Copy link
Copy Markdown

Questions about BackupActivation -

[1] What is the expected AFTResult of Modify response if the target NHG does not have a backup NHG ? Should the entry to accepted with FIB_PROGRAMMED/RIB_PROGRAMMED (per ACK mode) or rejected with FIB_FAILED ?

[2] Same question as above for the case where the target NHG has a backup NHG but all the backup NHs are down or nonviable ?

[3] Assuming backup NHG is in activated state. What is the expected behavor when all the backup nexthops go down or become nonviable? Should traffic be kept on the backup nexthops as expected, or switched back to viable primary nexthop(s) ?

@dplore

dplore commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

Deviate unsupported decap-mpls-label-stacks and encap-mpls-label-stacks for this release. These leaves may be added when there is a specific use for them in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants