Skip to content

adding macsec telemetry path mapping of OC to Juniper native paths - #18

Merged
navaneethyv merged 10 commits into
openconfig:mainfrom
sudhirakondi:jnpr-func-trans
Sep 27, 2026
Merged

navaneethyv merged 10 commits into
openconfig:mainfrom
sudhirakondi:jnpr-func-trans

Conversation

@sudhirakondi

Copy link
Copy Markdown
Contributor

Code changes required for adding mapping of openconfig paths to juniper native paths necessary for macsec-1.1 test.

@sudhirakondi

Copy link
Copy Markdown
Contributor Author

/gemini review

@sudhirakondi

Copy link
Copy Markdown
Contributor Author

/gemini review

Comment thread juniper/junipermacsecstate/junipermacsecstate.go
Comment thread juniper/juniperamacsecstate/juniperamacsecstate.go Outdated
Comment thread juniper/juniperamacsecstate/juniperamacsecstate.go Outdated
Comment thread juniper/junipermacseccounters/junipermacseccounters.go
Comment thread juniper/junipermacseccounters/junipermacseccounters.go
Comment thread juniper/juniperamacsecstate/juniperamacsecstate.go Outdated
Comment thread juniper/junipermacseccounters/junipermacseccounters.go
Comment thread juniper/junipermacsecstate/junipermacsecstate.go
Comment thread juniper/juniperamacsecstate/juniperamacsecstate.go Outdated
@sudhirakondi

Copy link
Copy Markdown
Contributor Author

hi @ashishpawar-google
I have addressed all comments. Also realized there was a typo extra 'a' in the name of the files. Have corrected that., as well few other optimizations using AI assisted code. Kindly review.

Comment thread juniper/junipermacseccounters/junipermacseccounters.go Outdated
Comment thread juniper/junipermacseccounters/junipermacseccounters_test.go Outdated
Comment thread juniper/junipermacsecstate/junipermacsecstate.go Outdated
Comment thread juniper/junipermacsecstate/junipermacsecstate.go Outdated
Comment thread juniper/junipermacsecstate/junipermacsecstate.go Outdated
Comment thread juniper/junipermacsecstate/junipermacsecstate.go Outdated
@sudhirakondi

Copy link
Copy Markdown
Contributor Author

/gemini review

@ksgireesha

Copy link
Copy Markdown

Thanks @ashishpawar-google for the review and approval!

Could a maintainer please help merge this PR when ready? We have downstream PR openconfig/featureprofiles#5627 waiting on this dependency to unblock test execution and validation.

CC: @navaneethyv, @rohit-rp

@navaneethyv
navaneethyv merged commit 3db7ee4 into openconfig:main Sep 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants