feat: Parse and verify RISCV stack operations#809
Merged
Conversation
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: 85367f4 | Previous: 74ee571 | Ratio |
|---|---|---|---|
add-fold-worklist/create |
2226000 ns (± 106330) |
1853000 ns (± 23158) |
1.20 |
add-fold-worklist/rewrite |
3768000 ns (± 297353) |
3362000 ns (± 53630) |
1.12 |
add-fold-worklist-local/create |
2290000 ns (± 103468) |
1865000 ns (± 91759) |
1.23 |
add-fold-worklist-local/rewrite |
3044000 ns (± 38473) |
2833000 ns (± 66759) |
1.07 |
add-zero-worklist/create |
2208000 ns (± 50715) |
1844000 ns (± 85301) |
1.20 |
add-zero-worklist/rewrite |
2497000 ns (± 86002) |
2174000 ns (± 31092) |
1.15 |
add-zero-reuse-worklist/create |
1824500 ns (± 88529) |
1558000 ns (± 10320) |
1.17 |
add-zero-reuse-worklist/rewrite |
1984500 ns (± 40153) |
1767000 ns (± 20550) |
1.12 |
mul-two-worklist/create |
2216000 ns (± 33731) |
1855000 ns (± 83071) |
1.19 |
mul-two-worklist/rewrite |
5228000 ns (± 64213) |
4729000 ns (± 61733) |
1.11 |
add-fold-forwards/create |
2191000 ns (± 76917) |
1874000 ns (± 87837) |
1.17 |
add-fold-forwards/rewrite |
3018000 ns (± 27392) |
2683000 ns (± 39771) |
1.12 |
add-zero-forwards/create |
2222000 ns (± 71248) |
1876500 ns (± 94595) |
1.18 |
add-zero-forwards/rewrite |
1974000 ns (± 25704) |
1725000 ns (± 29016) |
1.14 |
add-zero-reuse-forwards/create |
1836000 ns (± 43365) |
1554000 ns (± 47788) |
1.18 |
add-zero-reuse-forwards/rewrite |
1528000 ns (± 54684) |
1499000 ns (± 69831) |
1.02 |
mul-two-forwards/create |
2201000 ns (± 104610) |
1853000 ns (± 86130) |
1.19 |
mul-two-forwards/rewrite |
3650000 ns (± 75145) |
3230000 ns (± 97941) |
1.13 |
add-zero-reuse-first/create |
1771000 ns (± 91141) |
1540000 ns (± 45075) |
1.15 |
add-zero-reuse-first/rewrite |
8000 ns (± 1278) |
9000 ns (± 408) |
0.89 |
add-zero-lots-of-reuse-first/create |
1897000 ns (± 94203) |
1556000 ns (± 27499) |
1.22 |
add-zero-lots-of-reuse-first/rewrite |
782000 ns (± 27004) |
750000 ns (± 12582) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
regehr
reviewed
Jun 9, 2026
Collaborator
|
I'm onboard with |
math-fehr
approved these changes
Jun 9, 2026
Collaborator
|
But let's wait for @regehr to approve it once the comments are addressed |
b7dab82 to
5c6c869
Compare
Contributor
Author
|
Updated as discussed, and the stack slot type becomes unnecessary. |
This departs a bit from xdslproject/xdsl#6086 as alloca expects a value_type attribute to determine the size of the allocation, and it returns a RISCV register.
This reverts commit 12d1ef2.
5c6c869 to
85367f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This departs a bit from xdslproject/xdsl#6086 as alloca expects a value_type attribute to determine the size of the allocation, and it returns a RISCV register.