Skip to content

fix(oc-docs): unify topbar control heights and convert sizing to rem - #138

Merged
bijin-bruno merged 1 commit into
opencollection-dev:mainfrom
sundram-bruno:fix/oc-docs-open-in-bruno-btn-size
Jul 22, 2026
Merged

fix(oc-docs): unify topbar control heights and convert sizing to rem#138
bijin-bruno merged 1 commit into
opencollection-dev:mainfrom
sundram-bruno:fix/oc-docs-open-in-bruno-btn-size

Conversation

@sundram-bruno

@sundram-bruno sundram-bruno commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Aligns the topbar controls to a uniform height and moves their sizing to rem.

What changed (behaviour)

  • Topbar controls now share a uniform 1.75rem (28px) height: theme toggle, env switcher, Open-in-Bruno, and the search bar (plus the hamburger/search icon buttons that were already 1.75rem / 28px).
  • Theme toggle grew from 1.625rem (26px) to 1.75rem (28px) square.
  • Env switcher box grew from ~1.625rem (~26px) to 1.75rem (28px) (fixed height replaces the vertical padding).
  • Open-in-Bruno is visually unchanged (kept at 1.75rem / 28px, weight 600, 1rem / 16px glyph).
  • Search bar is visually unchanged (already 1.75rem / 28px).

Non-behavioural

  • Converted px sizing to rem across Open-in-Bruno, theme toggle, env switcher, show-vars toggle, and the search bar. Same rendered size at the default 16px root, but now scales with the user's font size.
  • Show-vars toggle: pure px to rem, no size change.
  • Left as px on purpose: the env-switcher (max-width: 640px) and show-vars (max-width: 900px) media-query breakpoints, and the show-vars toggle track's 999px pill radius.

@sundram-bruno
sundram-bruno marked this pull request as draft July 22, 2026 10:15
@sundram-bruno
sundram-bruno marked this pull request as ready for review July 22, 2026 10:18

@vasharma05-bruno vasharma05-bruno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread packages/oc-docs/src/components/EnvSwitcher/StyledWrapper.ts
@bijin-bruno
bijin-bruno merged commit 420b8b1 into opencollection-dev:main Jul 22, 2026
1 check passed
@sundram-bruno sundram-bruno changed the title fix(oc-docs): unify topbar control heights to 28px and convert sizing to rem fix(oc-docs): unify topbar control heights and convert sizing to rem Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants