fix(oc-docs): cap menu dropdown height so long lists scroll - #137
Merged
bijin-bruno merged 1 commit intoJul 22, 2026
Conversation
The assertion operator dropdown lists 28 options; the shared MenuDropdown surface was capped at 90vh, which measures the browser viewport rather than the embedded component, so the list spilled past the app. Cap the surface at min(20rem, 90vh) so long lists scroll instead of overflowing.
vasharma05-bruno
force-pushed
the
fix/assertion-operator-dropdown-height
branch
from
July 22, 2026 04:45
3635d5e to
3211c62
Compare
sachin-bruno
approved these changes
Jul 22, 2026
bijin-bruno
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening the operator dropdown in the assertions table (playground) renders all 28 options at full height. The shared
MenuDropdownsurface was capped atmax-height: 90vh, butvhis the browser viewport height, not the embedded OpenCollection component's height — so the list spilled well past the app area.Before
After
Fix
Cap the dropdown surface at
min(20rem, 90vh)so a long list scrolls inside the popover instead of overflowing.20remshows ~12 items;min(…, 90vh)keeps it safe on small viewports. Short-list dropdowns (env switcher, body-mode, query bar, select) never reach the cap, so they're unaffected.Change is a single CSS line in
src/ui/MenuDropdown/StyledWrapper.ts.Testing
npm run lint— no new problems (identical count vs. main)npm run test:run— all MenuDropdown/AssertsTab unit tests pass