fix(oc-docs): dismiss playground overlay sidebar on outside click and fix dark-mode shadow - #132
Merged
bijin-bruno merged 2 commits intoJul 22, 2026
Conversation
… fix dark-mode shadow The inline-dock sidebar overlays the view but only closed on navigation, so a click outside it did nothing. Add a backdrop that closes it, mirroring the docs navigation drawer. Also swap the overlay's text-tinted color-mix shadow (which turned whitish in dark mode) for the theme-aware --oc-shadow-md token, drop the doubled border-right in overlay mode, and move the docs drawer onto the same token.
sundram-bruno
force-pushed
the
fix/oc-docs-playground-sidebar-dismiss
branch
from
July 21, 2026 09:39
cc154c3 to
516cfc1
Compare
…for playground overlay Add useClickOutside so the inline-dock sidebar also closes when clicking outside the playground, alongside the backdrop that blocks clicks over the view. Extend the hook with an optional ignoreSelector so the sidebar toggle is not treated as outside (which would reopen it). Replace the hardcoded overlay z-indexes with the --z-sidebar token.
vasharma05-bruno
approved these changes
Jul 22, 2026
bijin-bruno
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close the inline-dock playground sidebar on outside click (backdrop), and replace its whitish dark-mode shadow with the theme-aware --oc-shadow-md token (also drops the doubled border and moves the docs drawer onto the same token).
JIRA : BRU-3753