Updated PVForecastForm to match backend API - #289
Open
AdityaShome wants to merge 1 commit into
Open
Conversation
Contributor
|
Ive now made a new api in V1, do we think we should still merge this? |
Author
|
Thanks, I have checked out api endpoints on the updated repository for both versions. But previous issue remains due to the raw values being sent, instead of the schema the backend expects. I tested with the changes, by wrapping the payload under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description/ Reason
The frontend request didn’t match the backend API:
POST /forecast(missing trailing slash) → 404{ site: { ... } }→ 422data.power_kwinstead ofdata.predictions.power_kw→ empty UIThis PR aligns the frontend with the FastAPI schema and the actual response shape so predictions render.
Fixes
dashboards/dashboard_1/src/components/PVForecastForm.tsxPOST http://localhost:8000/forecast/(with trailing slash){ site: values }data.predictions.power_kwHow Has This Been Tested?
cd dashboards/dashboard_1 npm install npm run devNotes
http://localhost:5173inapi/v0/app/main.py.Checklist: