Conversation
There was a problem hiding this comment.
@braddf the main focus for this pr should be this file
|
@braddf, apart from the file I said on, please feel free to skim through the rest since most of the files are auto-generated by fastapi-template. The testing framework is set up, but there aren’t any real tests yet; I plan to add them later this week for the S3 fetch. The same goes for the README.md. |
braddf
left a comment
braddf
left a comment
There was a problem hiding this comment.
Just leaving these couple of comments from before our chat this morning, let me know when the update is ready for review! 👍
braddf
left a comment
braddf
left a comment
There was a problem hiding this comment.
Quite a few comments, most should be easy changes, and let me know if you are uncertain about anything. I have been fairly strict, as I think what you've done merits a higher level of attention to detail and design standards 👍
|
|
||
| class InterceptHandler(logging.Handler): | ||
| """ | ||
| Default handler from examples in loguru documentation. |
There was a problem hiding this comment.
Haven't used loguru before, but will give it a go!
| "cloudcasting_backend/static/layers" # Base directory for all GeoTIFF output | ||
| ) | ||
| # Bounding box for cropping the GeoTIFF output [lon_min, lat_min, lon_max, lat_max] | ||
| GEOTIFF_BBOX = [-19.0, 42.0, 15.0, 65.0] |
There was a problem hiding this comment.
Is this the same for both MET-10 and MET-11?
3f4c8fc to
efd7cc8
Compare
|
Great stuff, thanks for adding those last comments as issues – I'll merge this in now 👍 |
2 participants
No description provided.