fix: prevent database column parameter deprecation#799
Merged
anonymoususer72041 merged 1 commit intoJun 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
DatabaseConnection::getColumn()method signature to avoid a PHP deprecation caused by an optional parameter being declared before required parameters.The previous signature declared
$querywith a default value even though$rowand$columnwere required. Modern PHP versions implicitly treat this as required and emit a deprecation warning when the file is loaded.The change removes the unnecessary default value from
$query. Existing call sites already pass all three arguments, so no call-site changes are required and the existing behavior is preserved.Validation was performed by linting
lib/DatabaseConnection.phpand loading the file withE_ALLenabled to confirm that theDatabaseConnection::getColumn()parameter-order deprecation is no longer emitted.