Table validation#255
Merged
Merged
Conversation
Restructured Validation result for code reusability. Integrated the validators.
Updated UCD Validator to warn for deprecated ucd. Upgraded validations code to list all the errors and warnings. Rearranged some of the code of cadc-tap-schema. Added int test cases for all errors, errors + warnings, and all warnings case. Added unit test for verifying local and remote(IVOA) ucd files are in sync.
Fixed tests affected by the changes.
# Conflicts: # cadc-tap-schema/src/main/java/ca/nrc/cadc/tap/schema/TapSchemaUtil.java
Commented ucd files related tests.
Taplint fixes
…tors. code refactoring and restructuring.
Configurable youcat for validation
Wrong Positions mentioned in messages. Renamed a ViolationType. Made structural violations to be considered as an error for all the config types.
…om cadc-tap improve tests of invalid input
…to table-validation
cadc-tap-server: update BasicUploadManager to use table validation from cadc-tap
table name and column name where appropriate
this avoids a null pointer in a service that doesn't configure
Table validation cosmetic improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges in extensive changes to add table validation to the cadc-tap library
Table validation can be enabled in the draft VOSI-tables endpoint code to validate user table creation and is used in the TAP upload support.
youcatcan be configured with different levels of validation: none, lax, strictprototype: there is also hack to run validation on an existing table in a TAP service