fix: remediate open Dependabot alerts (lodash, picomatch) - #49
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR remediates open Dependabot/audit findings by pinning patched minimum versions for vulnerable transitive dependencies via root pnpm.overrides, regenerating the lockfile, and extending the existing override contract test while documenting the change in the changelog and an April ExecPlan.
Changes:
- Add
pnpm.overridesfloors forlodash,picomatch, and a narrow dev-onlybrace-expansionadvisory path. - Refresh
pnpm-lock.yamland extendtests/node/dependency-security-overrides.test.tsto enforce the new floors and absence of vulnerable resolutions. - Record the remediation in
CHANGELOG.mdand a newdocs/execplans/...document.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/node/dependency-security-overrides.test.ts | Extends the security override contract assertions to cover the new override keys and lockfile resolutions. |
| package.json | Adds new pnpm.overrides entries to pin patched transitive minimum versions. |
| pnpm-lock.yaml | Updates override map and resolved package graph to remove vulnerable exact versions. |
| CHANGELOG.md | Documents the security-floor remediation in the changelog. |
| docs/execplans/dependabot-alert-remediation-2026-04.md | Adds an ExecPlan capturing remediation context, steps, and validation commands. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lodashandpicomatchthrough rootpnpm.overridespnpm-lock.yamlso the vulnerable exact resolutions are gone from the dependency graphbrace-expansionpath narrowly sopnpm audit --jsonis clean on the branchRoot cause
GitHub Dependabot currently reports 3 open alerts on
main, but they collapse to two vulnerable transitive packages in the lockfile:lodashviadiscord.js -> @sapphire/shapeshiftpicomatchvia@tktco/node-actionlint -> fast-glob -> micromatchThe full audit gate also exposed a remaining dev-only
brace-expansionadvisory through the Vitest coverage toolchain, so this PR clears that narrow path too without broad dependency churn.Validation
node --test --import tsx/esm tests/node/dependency-security-overrides.test.tspnpm audit --prod --jsonpnpm audit --jsonpnpm verify:all